Re: [Libguestfs] [PATCH 1/2] v2v: -i disk: Move code that creates name from disk to separate module.

On Friday, 9 September 2016 15:09:56 CEST Richard W.M. Jones wrote:

Simple code motion. --- v2v/Makefile.am | 2 ++ v2v/input_disk.ml | 21 ++------------------- v2v/name_from_disk.ml | 41 +++++++++++++++++++++++++++++++++++++++++ v2v/name_from_disk.mli | 24 ++++++++++++++++++++++++ 4 files changed, 69 insertions(+), 19 deletions(-) create mode 100644 v2v/name_from_disk.ml create mode 100644 v2v/name_from_disk.mli

Looks good -- I'd have put it in Utils though, instead of a new module with just a single simple function. -- Pino Toscano