On Sun, Dec 04, 2011 at 04:45:27PM -0800, Alex Nelson wrote:
On Oct 20, 2011, at 04:46 , Richard W.M. Jones wrote:
On Thu, Oct 20, 2011 at 12:37:54PM +0100, Richard W.M. Jones wrote:
of the tests could have picked up this type of bug. I think the tests (all of them) need to be changed to be more thorough.
And while you're doing that, is there a way to avoid the hard-coded '297680'?
I suggest two possibilities: create another test hive (derived from 'large') which will be specific to this test and we will never change in future. Since this won't change, we can go ahead and use hard-coded offsets.
I see two options for the test hive.
The first, which I would prefer, is to use an openly available hive from a research disk image. For example, digitalcorpora.org has several Windows computer disk images immediately available for analysis. Any hive from there could be included as a sample in the images/ directory. Unfortunately, I don't know how well this would work with the GPL.
I checked this out, and it's not possible. Our test hive 'minimal' was specially constructed so it does not contain anything copyrightable. 'large' was constructed from 'minimal' by a mechanical process. Nevertheless Digital Corpora looks interesting and useful. I need to see if we can add tests (including for libguestfs) that would use that for people who had downloaded the corpus themselves.
Alternatively, there is the attached patch, which adds a not-too-creatively named hive generated from ''minimal'. (I didn't see a benefit to deriving it from 'large,' but it's easy enough to modify that.)
OK. The patch is the sort of thing I was suggesting. This is going to be combined with the revised patch series? [...] Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v