On 04/02/10 09:47, Richard W.M. Jones wrote:
On Mon, Feb 01, 2010 at 05:23:32PM +0000, Matthew Booth wrote:
+sub _configure_default_devices +{ + my ($dom, $default_dom) = @_; + + my ($devices) = $dom->findnodes('/domain/devices'); + + # Remove any existing input, graphics or video devices + foreach my $input ($devices->findnodes('input | video | graphics')) { + $devices->removeChild($input); + } + + my ($input_devices) = $default_dom->findnodes('/domain/devices'); + + # Add new default devices from default XML + foreach my $input ($input_devices->findnodes('input | video | graphics')) { + my $new = $input->cloneNode(1); + $new->setOwnerDocument($devices->getOwnerDocument()); + $devices->appendChild($new); + } +}
How do we know that the guest has drivers for these, or do we just assume that any guest can drive a basic Cirrus card etc?
Well, we're short on choices. If it can't drive a basic Cirrus card, it can't have graphics, so I guess this doesn't hurt.
What sort of devices do ESX guests come configured with? Is the XML generated by the libvirt ESX driver an accurate reflection of this?
The ESX driver XML output doesn't include any input, graphics or video elements [1]. VMware guests use the 'vmware' X driver, which afaict is provided by VMwareTools. Matt [1] I should file a bug about that. -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490