On 1/17/24 06:23, Laszlo Ersek wrote:
(2) A further question: now I wanted to recheck how "Ssh.download_file uri" actually uses the password file passed in with "-ip", and the answer, as far as I can tell, is that it doesn't!
The manual <https://libguestfs.org/virt-v2v-input-vmware.1.html> says,
Note that support for non-interactive authentication via the -ip option is incomplete. Some operations remain that still require the user to enter the password manually. Therefore ssh-agent is recommended over the -ip option. See https://bugzilla.redhat.com/1854275.
which certainly brings back some unpleasant :) memories -- and the BZ is indeed called 'document that vmx+ssh "-ip" auth doesn't cover ssh / scp shell commands'.
OK, so long story short: is it the case that this patch series actually *extends* "-ip" support to "-i vmx -it ssh"? Because in that case, I think we should update the documentation as well.
Haha, just started reading patch#6, and I see you mention exactly this in the commit message! So yes, updating the manual certainly seems justified. Thanks! Laszlo