On Mon, Oct 03, 2016 at 03:46:06PM +0200, Pino Toscano wrote:
+/* Add drives, inspect and mount. */ +static int +add_and_mount (struct drv *drvs, struct mp *mps, int *windows_ret) +{
The 'windows_ret' out parameter does not seem used outside, so could be better to drop it for now/
Oops, a missing feature. I need to implement it!
+ ret = disk_mtime (drvs->next);
This may be better written as simple non-recursive loop, to avoid neverending loop, and make the code slightly more understandable to follow (IMHO).
This is actually copied from fish/options.c which works the same way. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top