On 12/13/18 9:23 AM, Richard W.M. Jones wrote:
On Thu, Dec 13, 2018 at 08:55:41AM -0600, Eric Blake wrote:
diff --git a/tests/Makefile.am b/tests/Makefile.am index 4c7b59c..55db593 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -32,7 +32,8 @@
include $(top_srcdir)/common-rules.mk
-MAINTAINERCLEANFILES = +CLEANFILES =
Because common-rules.mk defines CLEANFILES, this should be giving a warning. And also because of that ...
I didn't notice the warning - but agree that slamming the variable back to empty is not desired ;)
+CLEANFILES += \ + test_ocaml_plugin.cmx \ + test_ocaml_plugin.cmi \ + test-ocaml-plugin.so
... this should not be necessary because the CLEANFILES rule in common-rules.mk cleans these files already.
If that is fixed, ACK.
Fixed and pushed. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org