Hi Rich, You're right, I had too many new additions. Please find attached a revision of this patch. I also found I misnamed one of the binding functions and forgot its prototype. That's fixed now. `make check` had all tests pass, 1 test not run. Sorry for not running that earlier. Neither of the other patches are directly affected by this, but if you need me to resubmit them anyway please let me know. I ran `make check` against the branch that also has those two patches' changes. --Alex On Sep 6, 2011, at 06:27 , Richard W.M. Jones wrote:
On Thu, Sep 01, 2011 at 06:17:31PM -0700, Alex Nelson wrote:
RLenNode and RLenValue are similar to RLenType, though with one less argument. This required adding one processing function for OCaml and Python.
Seems like this patch is partly unnecessary?
At least, nothing in any later patch appears to return RLenNode. The two functions that previously used this now return RSize (which is a good thing).
As for RLenValue, the new function value_data_cell_offset returns this, so this part of the patch should be included. I think you should rework this patch.
Rich.
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/