On 11/18/2009 01:46 PM, Richard W.M. Jones wrote:
On Wed, Nov 18, 2009 at 01:41:13PM +0000, Matthew Booth wrote:
Parallel make was failing because guestfs-structs.h was required before generator.ml ran.
Unfortunately this patch fully reverts:
http://git.annexia.org/?p=libguestfs.git;a=commitdiff;h=efad4f53923dcca94613...
which was necessary to stop the generator being rerun all the time. I'd prefer one where we just specify the files that are necessary. Or a more detailed analysis of why every single $(BUILT_SOURCES) file is really necessary here.
See also:
http://git.annexia.org/?p=libguestfs.git;a=commitdiff;h=a6832406fabf251ba89e...
Looking at it, they're clearly all necessary. I stand by this patch. Presumably the rebuilds are caused by generator.ml being re-run unnecessarily. Can you give me an example of an unnecessary rebuild? Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490