[Libguestfs] [PATCH nbdkit v3 3/3] retry: Add a test of this filter.

We use a custom sh plugin to test retries are working. --- tests/Makefile.am | 8 +++ tests/test-retry-reopen-fail.sh | 108 ++++++++++++++++++++++++++++++++ tests/test-retry.sh | 97 ++++++++++++++++++++++++++++ 3 files changed, 213 insertions(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index 1b1e05b..af9b9d9 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -114,6 +114,8 @@ EXTRA_DIST = \ test-reflection-address.sh \ test-reflection-base64.sh \ test-reflection-raw.sh \ + test-retry.sh \ + test-retry-reopen-fail.sh \ test-shutdown.sh \ test-ssh.sh \ test.tcl \ @@ -1040,6 +1042,12 @@ test_readahead_SOURCES = test-readahead.c test.h test_readahead_CFLAGS = $(WARNINGS_CFLAGS) $(LIBGUESTFS_CFLAGS) test_readahead_LDADD = libtest.la $(LIBGUESTFS_LIBS) +# retry filter test. +TESTS += \ + test-retry.sh \ + test-retry-reopen-fail.sh \ + $(NULL) + # truncate filter tests. TESTS += \ test-truncate1.sh \ diff --git a/tests/test-retry-reopen-fail.sh b/tests/test-retry-reopen-fail.sh new file mode 100755 index 0000000..a6279b8 --- /dev/null +++ b/tests/test-retry-reopen-fail.sh @@ -0,0 +1,108 @@ +#!/usr/bin/env bash +# nbdkit +# Copyright (C) 2018-2019 Red Hat Inc. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions are +# met: +# +# * Redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer. +# +# * Redistributions in binary form must reproduce the above copyright +# notice, this list of conditions and the following disclaimer in the +# documentation and/or other materials provided with the distribution. +# +# * Neither the name of Red Hat nor the names of its contributors may be +# used to endorse or promote products derived from this software without +# specific prior written permission. +# +# THIS SOFTWARE IS PROVIDED BY RED HAT AND CONTRIBUTORS ''AS IS'' AND +# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, +# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A +# PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL RED HAT OR +# CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF +# USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND +# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, +# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT +# OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF +# SUCH DAMAGE. + +# This test is similar to test-retry.sh but it also tests the case +# where the reopen operation fails. + +source ./functions.sh +set -e +set -x + +requires qemu-img --version +requires stat --version + +files="retry-reopen-fail.img retry-reopen-fail-start + retry-reopen-fail-count retry-reopen-fail-open-count" +rm -f $files +cleanup_fn rm -f $files + +touch retry-reopen-fail-start + +# Create a custom plugin which will test retrying. +nbdkit -v -U - --filter=retry \ + sh - \ + --run 'qemu-img convert $nbd retry-reopen-fail.img' <<'EOF' +case "$1" in + open) + # Count how many times the connection is (re-)opened. + i=`cat retry-reopen-fail-open-count` + ((i++)) + echo $i > retry-reopen-fail-open-count + if [ $i -eq 2 ]; then + echo "EIO open failed" >&2 + exit 1 + fi + ;; + pread) + # Fail 3 times then succeed, and count how long it takes. + i=`cat retry-reopen-fail-count` + ((i++)) + echo $i > retry-reopen-fail-count + if [ $i -le 3 ]; then + echo "EIO pread failed" >&2 + exit 1 + else + dd if=/dev/zero count=$3 iflag=count_bytes + fi + ;; + + get_size) echo 512 ;; + *) exit 2 ;; +esac +EOF + +# In this test we should see 4 failures: +# pread FAILS +# retry and wait 2 seconds +# open FAILS +# retry and wait 4 seconds +# open succeeds +# pread FAILS +# retry and wait 8 seconds +# pread FAILS +# retry and wait 16 seconds +# pread succeeds + +# The minimum time for the test should be 2+4+8+16 = 30 seconds. +start_t=`stat -c '%Z' retry-reopen-fail-start` +end_t=`date +'%s'` +if [ $((end_t - start_t)) -lt 30 ]; then + echo "$0: test ran too quickly" + exit 1 +fi + +# Check the handle was opened 5 times. +retry_open_count=`cat retry-reopen-fail-open-count` +if [ $retry_open_count -ne 5 ]; then + echo "$0: retry-reopen-fail-open-count ($retry_open_count) != 5" + exit 1 +fi diff --git a/tests/test-retry.sh b/tests/test-retry.sh new file mode 100755 index 0000000..47d6e23 --- /dev/null +++ b/tests/test-retry.sh @@ -0,0 +1,97 @@ +#!/usr/bin/env bash +# nbdkit +# Copyright (C) 2018-2019 Red Hat Inc. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions are +# met: +# +# * Redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer. +# +# * Redistributions in binary form must reproduce the above copyright +# notice, this list of conditions and the following disclaimer in the +# documentation and/or other materials provided with the distribution. +# +# * Neither the name of Red Hat nor the names of its contributors may be +# used to endorse or promote products derived from this software without +# specific prior written permission. +# +# THIS SOFTWARE IS PROVIDED BY RED HAT AND CONTRIBUTORS ''AS IS'' AND +# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, +# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A +# PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL RED HAT OR +# CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF +# USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND +# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, +# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT +# OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF +# SUCH DAMAGE. + +source ./functions.sh +set -e +set -x + +requires qemu-img --version +requires stat --version + +files="retry.img retry-start retry-count retry-open-count" +rm -f $files +cleanup_fn rm -f $files + +touch retry-start + +# Create a custom plugin which will test retrying. +nbdkit -v -U - --filter=retry \ + sh - \ + --run 'qemu-img convert $nbd retry.img' <<'EOF' +case "$1" in + open) + # Count how many times the connection is (re-)opened. + i=`cat retry-open-count` + echo $((i+1)) > retry-open-count + ;; + pread) + # Fail 3 times then succeed, and count how long it takes. + i=`cat retry-count` + ((i++)) + echo $i > retry-count + if [ $i -le 3 ]; then + echo "EIO pread failed" >&2 + exit 1 + else + dd if=/dev/zero count=$3 iflag=count_bytes + fi + ;; + + get_size) echo 512 ;; + *) exit 2 ;; +esac +EOF + +# In this test we should see 3 failures: +# pread FAILS +# retry and wait 2 seconds +# pread FAILS +# retry and wait 4 seconds +# pread FAILS +# retry and wait 8 seconds +# pread succeeds + +# The minimum time for the test should be 2+4+8 = 14 seconds. +start_t=`stat -c '%Z' retry-start` +end_t=`date +'%s'` +if [ $((end_t - start_t)) -lt 14 ]; then + echo "$0: test ran too quickly" + exit 1 +fi + +# Check the handle was opened 4 times (first open + one reopen for +# each retry). +retry_open_count=`cat retry-open-count` +if [ $retry_open_count -ne 4 ]; then + echo "$0: retry-open-count ($retry_open_count) != 5" + exit 1 +fi -- 2.23.0