On 3/8/23 22:35, Richard W.M. Jones wrote:
On Tue, Mar 07, 2023 at 09:40:07PM +0200, Andrey Drobyshev wrote:
Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com> --- convert/convert_windows.ml | 1 + 1 files changed, 1 insertions(+)
diff --git a/convert/convert_windows.ml b/convert/convert_windows.ml index 9d8d271d..4f672487 100644 --- a/convert/convert_windows.ml +++ b/convert/convert_windows.ml @@ -273,6 +273,7 @@ let convert (g : G.guestfs) _ inspect i_firmware _ static_ips =
and of_virtio_win_block_type = function | Inject_virtio_win.Virtio_blk -> Virtio_blk + | Inject_virtio_win.Virtio_SCSI -> Virtio_SCSI | IDE -> IDE
You don't need the "Inject_virtio_win." prefix there, since OCaml will infer from the first line (which has the prefix) that you mean the type from Inject_virtio_win instead of the same-named type from lib/types.mli. (Although as you can see it works either way). It's probably better to omit it, since it is also omitted on the third (IDE) line, or I suppose adjust the third line to add it.
Agreed, makes sense, thanks for pointing out.
Rich.
and of_virtio_win_net_type = function -- 2.31.1