On Fri, May 07, 2010 at 01:25:23PM +0100, Matthew Booth wrote:
On 07/05/10 11:42, Richard W.M. Jones wrote:
On Fri, May 07, 2010 at 11:10:04AM +0100, Matthew Booth wrote:
On 06/05/10 17:55, Richard W.M. Jones wrote:
From fe19327ca120f2bc08229e495da0caf0c9141cb6 Mon Sep 17 00:00:00 2001 From: Richard Jones <rjones@redhat.com> Date: Thu, 6 May 2010 17:53:09 +0100 Subject: [PATCH 2/2] Pre-convert Windows guests.
--- lib/Sys/VirtV2V/Converter/Windows.pm | 156 ++++++++++++ lib/Sys/VirtV2V/GuestOS/Windows.pm | 464 ++++++++++++++++++++++++++++++++++ v2v/virt-v2v.conf | 25 ++ 3 files changed, 645 insertions(+), 0 deletions(-) create mode 100644 lib/Sys/VirtV2V/Converter/Windows.pm create mode 100644 lib/Sys/VirtV2V/GuestOS/Windows.pm
With a little cut/paste you could put everything in GuestOS::Windows into Converter::Windows. I'm trying to move things out of there, not in!
So then we wouldn't have a GuestOS::Windows class at all, or would we need an empty one?
It's not required at all.
The attached version combines everything into a single module. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora