On 01/23/2018 01:04 PM, Richard W.M. Jones wrote:
nbdkit <= 1.1.28 defaulted to the oldstyle protocol for compatibility with qemu and libguestfs. However qemu >= 2.6 can now work with either protocol and is widely installed. Also newstyle is required for newer features such as export names and TLS. In addition nbd-client dropped support for oldstyle entirely.
You can select the oldstyle protocol by adding ‘-o’, and it is still tested.
Looks right to me.
--- TODO | 6 ++++++ docs/nbdkit.pod | 29 +++++++++++++++-------------- src/main.c | 2 +- tests/test-single.sh | 2 +- 4 files changed, 23 insertions(+), 16 deletions(-)
(Yay - my test-nbd was already set up for proper explicit use of -o vs. -n, so it still covers both styles regardless of the default) -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org