Re: [Libguestfs] [PATCH 2/6] v2v: rhv-upload-plugin: Use API_VERSION 2

On Sat, Jan 23, 2021, 08:28 Richard W.M. Jones <rjones(a)redhat.com&gt; wrote: On Sat, Jan 23, 2021 at 12:45:20AM +0200, Nir Soffer wrote: >  @failing > -def pwrite(h, buf, offset): > +def pwrite(h, buf, offset, flags): >      http = h['http'] >  >      count = len(buf) > @@ -234,7 +253,7 @@ def pwrite(h, buf, offset): >  >  >  @failing > -def zero(h, count, offset, may_trim): > +def zero(h, count, offset, flags): Assume there's no way to pass the possible FUA flag through to oVirt here? We have flush=true, which send nbd flush command after the write/zero. Maybe we could handle flush=true as fua when using nbd backend, I'm not sure how important is this. I think we miss converting fua to flush=true to have full api 2 support.