On Wed, Aug 12, 2009 at 07:33:44PM +0200, Jim Meyering wrote:
Richard W.M. Jones wrote:
On Wed, Aug 12, 2009 at 06:52:37PM +0200, Jim Meyering wrote:
@@ -4474,7 +4475,8 @@ check_state (guestfs_h *g, const char *caller) | args -> List.iter ( function - | String n -> + (* FIXME *) + | Device n | String n -> pr " args.%s = (char *) %s;\n" n n | OptString n -> pr " args.%s = %s ? (char **) &%s : NULL;\n" n n n
What was the FIXME here? Looks OK to me.
Sorry about that. Those were notes to self to revisit. They're gone in the final result. I had already removed a few others from intermediate patches but didn't look back far enough. I can remove those as well, if you wish.
No it's fine, don't worry about them. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 75 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora