On Tue, Feb 21, 2017 at 02:59:38PM +0100, Pino Toscano wrote:
On Saturday, 18 February 2017 08:05:27 CET Richard W.M. Jones wrote:
A very miscellaneous set of cleanups to how we handle the Windows registry in virt-v2v, firstboot, and inspection code. This should all be straightforward non-controversial refactoring. Some highlights:
- Add a new mllib Registry module containing various utility functions that are currently scattered all around.
IMHO it should be better named as WinRegistry, although I won't hold my breath on it.
Originally I wrote it as Windows_registry. It was a bit long :-) Rich.
The rest of the changes LGTM (even if I'm not familiar with this code base).
Thanks, -- Pino Toscano
_______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org