On 9/29/20 6:23 AM, Richard W.M. Jones wrote:
This is not related to the current patch, but generally for libnbd:
(1) Should we be testing interop separately for qemu-storage-daemon (qsd), or is qsd basically qemu-nbd in a new wrapper so it's not worth doing it?
(2) I found a bug in the new nbdinfo behaviour:
$ nbdkit -fv file dir=/scratch
(where /scratch is a directory with a lot of files in it)
$ nbdinfo --version libnbd 1.5.3 $ nbdinfo --list nbd://localhost [... lots of files shown ...] nbd_opt_info: recv: Connection reset by peer
nbdkit gives this error:
nbdkit: file[1]: error: client exceeded maximum number of options (32)
Yeah, we really ought to raise nbdkit's limits when .list_exports returns a large list. We haven't yet released nbdkit 1.24 where the file driver actually has a large .list_exports; but it may also be a reason to figure out if libnbd should go to the effort of re-connecting for the later portion of a list on servers like older nbdkit that limit the length of the negotiation phase. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org