Re: [Libguestfs] [PATCH 3/3] Add tests for CoreOS
On Fri, May 29, 2015 at 12:26:24PM +0300, Nikos Skalkotos wrote:
diff --git a/inspector/Makefile.am b/inspector/Makefile.am
index 9d8303c..9c79bed 100644
--- a/inspector/Makefile.am
+++ b/inspector/Makefile.am
@@ -38,6 +38,7 @@ EXTRA_DIST = \
expected-fedora.img.xml \
expected-ubuntu.img.xml \
expected-archlinux.img.xml \
+ expected-coreos.img.xml \
expected-windows.img.xml \
test-virt-inspector.sh \
test-xmllint.sh.in \
I don't think this enables the test. I think you also need
to edit inspector/test-virt-inspector.sh, adding it to the
`for f in ../tests/guests/...' loop.
The patch series looks fine though, so I'm prepared to ACK this if the
changes I've requested are made.
Thanks,
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW