On Tue, Jul 02, 2019 at 10:09:00PM +0900, Hiroyuki Katsura wrote:
I fixed the patch I submitted before based on comments, and there are some commits which are merged or divided. So, I will re-send all the patches.
I looked at the v2 patches and I think they're in reasonable shape. There's been a lot of discussion of using ’git rebase --interactive’. I think that's a good thing, and also good practice if you're going to become a more frequent open source contributor. It helps people when they're reviewing patches. For this particular case I think we'd probably squash all the patches into a single commit when pushing them upstream. Have you decided whether we need to commit the generated files (Cargo.toml, Cargo.lock)? It looks like in this series those files are still included and not added to .gitignore. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html