On Mon, Dec 03, 2018 at 10:06:17PM -0600, Eric Blake wrote:
On 12/3/18 12:55 PM, Eric Blake wrote:
On 12/2/18 10:39 AM, Richard W.M. Jones wrote:
By default valgrind suppresses many leaks. I'm not even sure exactly how it decides which ones to suppress, but certainly global variables pointing to malloc’d data are suppressed, which is not useful behaviour.
+include $(top_srcdir)/common-rules.mk + +suppressions_files = $(wildcard *.suppressions)
A GNU make-ism - but you already mention requiring GNU make in README. Should we make ./configure error out hard if $MAKE is not GNU Make, rather than risking someone getting 80% though a build on BSD make and then choking when it gets here?
Worse, it fails in VPATH builds. It resulted in 'make distcheck' hanging on a 'cat > valgrind.suppressions' command, because the wildcard didn't find anything in $(builddir), when it should have been looking in $(srcdir).
I see you've fixed it already, thanks :-) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v