On Wednesday 04 November 2015 12:43:31 Margaret Lewicka wrote:
On 4 November 2015 at 12:37, Pino Toscano <ptoscano@redhat.com> wrote: [...]
NACK, these OS-specific blocks are hard to maintain, and it makes no sense to enclose POSIX headers in them.
Can you please try the attached patch? I see Rich already pushed your patch, but IMHO that should be reverted and this one should go...
Happy to. However, these same header files have been removed in 3b17152ec399acb35b23331d2c3b4f424a68824a:
commit 3b17152ec399acb35b23331d2c3b4f424a68824a Author: Richard W.M. Jones <rjones@redhat.com> Date: Tue Sep 29 21:58:41 2015 +0100
lib: Remove unused header files.
I used ESR's deheader program to look for unused includes. I then examined each instance by hand, and also test-compiled (on Linux).
...which makes me suspect it will happen again at some point unless there is some indication that it's a non-Linux include.
Well, it was because something else implicitly pulled it. Note that sys/un.h is a POSIX header, and it's needed for sockaddr_un [1]. [1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_un.h.html -- Pino Toscano