Re: [Libguestfs] [PATCH nbdkit 02/10] server: Don't set export_name as a side effect of using --run

On Sat, Sep 09, 2023 at 02:57:50PM +0100, Richard W.M. Jones wrote:

Reduce long-range code dependencies by not setting export_name in run_command (--run functionality), especially as this function is not always called.

If the -e option was not used at all then export_name will be NULL. --- server/captive.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com> For other reviewers, remember that -e only impacts $uri during --run (it is still up to the plugin whether the client must connect to a particular export name, and the client's choice is not forced by -e). -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org