21 Jul
2012
21 Jul
'12
11:05 a.m.
On Sat, Jul 21, 2012 at 03:27:14PM +0800, Wanlong Gao wrote:
Use this macro to simplify the code.
- style = RStruct ("info", "xfsinfo"), [Pathname "path"], []; + style = RStruct ("info", "xfsinfo"), [String "pathordevice"], [];
I think you should use Dev_or_Path here. See for example daemon/stubs.c:file_stub and daemon/file.c:do_file. Perhaps Dev_or_Path doesn't do the right thing, but in that case we should improve it, instead of just making things untyped. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v