Re: [Libguestfs] [PATCH V4 3/3] umount: use Dev_or_Path for the argument type

On Tue, Jul 24, 2012 at 06:57:49PM +0800, Wanlong Gao wrote: No, I was checking it in detail. The patch changes the sematics of 'umount', because the generator adds 'REQUIRE_ROOT_OR_RESOLVE_DEVICE'. In other words, umount will now require root. I thought that this would break mkmountpoint and friends, but in fact it turns out this is not the case. When I've finished testing it I'll push it provided I don't find any regressions. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org