12 Mar
2010
12 Mar
'10
3:58 p.m.
Richard W.M. Jones wrote:
Version 2 of the patch, integrating Jim Meyering's feedback, and tested by me locally.
I also ran it under valgrind. Obviously there's some leaked memory, which is to be expected because we intentionally don't free up some allocations. But there are no other memory problems (eg. use after free, out of bounds etc).
I forgot to mention that using readlink has a few problems, not to mention requiring a pre-sized buffer. If you use gnulib's xreadlink, you avoid both. I reviewed the incremental diffs, and they look fine, modulo the many longer-than-80-column lines.