Richard W.M. Jones wrote:
On Mon, Aug 03, 2009 at 05:39:42PM +0200, Jim Meyering wrote:
+Code indentation +---------------------------------------------------------------------- +Our C source code generally adheres to some basic code-formatting +conventions. The existing code base is not totally consistent on this +front, but we do prefer that contributed code be formatted similarly. +In short, use spaces-not-TABs for indentation, use 4 spaces for each +indentation level, and other than that, follow the K&R style. + +If you use Emacs, add the following to one of one of your start-up files +(e.g., ~/.emacs), to help ensure that you get indentation right: + + ;;; When editing C sources in libguestfs, use this style. + (defun libguestfs-c-mode () + "C mode with adjusted defaults for use with libguestfs." + (interactive) + (c-set-style "K&R") [...] + (setq c-indent-level 4) + (setq c-basic-offset 4))
I'm not a fan of using offsets of 4, and the existing code uses offsets of 2, so I'd prefer to keep that.
This is what I have in my .emacs now:
(defun libguestfs-c-mode () "C mode with adjusted defaults for use with libguestfs." (interactive) (setq indent-tabs-mode nil) ; indent using spaces, not TABs ) (add-hook 'c-mode-hook '(lambda () (if (string-match "/libguestfs" (buffer-file-name)) (libguestfs-c-mode))))
Adjusted via s/4/2/g (that was just blindly copied from libvirt).