On Mon, Jul 05, 2010 at 12:25:58PM -0400, Daniel P. Berrange wrote: [...] My only quibble about the API would be:
<fs> sockpath /tmp/guest/sock
Can we reuse the existing path variable for this?
<fs> launch
The temporary kernel/initrd from 'find-appliance' will be automatically deleted when the guestfs handle is closed.
Internally I think launch should delete the kernel/initrd (this is a change from current behaviour too). Nothing needs these after launch, not even external qemus, because qemu loads them into the appliance RAM. By deleting them early there is more chance that we don't leave these tmp files lying around.
Instead of using 'find-appliance' an app can manually invoke the febootstrap-supermin-helper to build the initrd/kernel but is a fragile coupling to libguestfs internals. Thus it is preferable to let libguestfs locate & inform you of the kernel and initrd
Agreed. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora