On Tuesday 23 February 2016 08:19:23 Richard W.M. Jones wrote:
Be explicit about what is exported from each module in the generator. ---
LGTM, just one note below.
[...]
diff --git a/generator/checks.mli b/generator/checks.mli new file mode 100644 index 0000000..4bbbda5 --- /dev/null +++ b/generator/checks.mli @@ -0,0 +1,18 @@ +(* libguestfs + * Copyright (C) 2009-2016 Red Hat Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + *) +
Can you please add a note that this module exports nothing on purpose, as it only does runtime checks for actions and other generator stuff? Thanks, -- Pino Toscano