On Wednesday, 5 December 2018 13:01:40 CET Richard W.M. Jones wrote:
On Wed, Dec 05, 2018 at 12:57:19PM +0100, Pino Toscano wrote:
Add few more characters for the devices of resume= entries in the command line of grub: this way it is possible to match also /dev/mapper devices.
This should require no further processing, since the names of the /dev/mapper devices do not change after the conversion.
Yes this is what worried me, but I think you're right.
I wanted to add an explanation out of the commit message, but apparently I overwrote it when re-exporting the patch... At least in my experience, guests may use /dev/mapper entries also in other places -- for example, a freshly installed Fedora 29 in VMware ESXi has in /etc/fstab: /dev/mapper/fedora_unused-root / xfs defaults 0 0 UUID=<some_uuid> /boot ext4 defaults 1 2 /dev/mapper/fedora_unused-swap swap swap defaults 0 0 Since the guest works fine (root & swap) after the conversion, and that so far we had no reports of problems due to /dev/mapper entries not changed, I thought that doing the same for resume= entries will cause any trouble. -- Pino Toscano