On Fri, Jul 15, 2022 at 03:30:56PM +0200, Laszlo Ersek wrote:
On 07/15/22 14:11, Richard W.M. Jones wrote:
Less churn version as described here: https://listman.redhat.com/archives/libguestfs/2022-July/029483.html
Couple of confusing points here, but I think I sorted them all out:
- the cover letter says 2/2 instead of 0/2
Because I edited it manually, and incorrectly :-(
- it wasn't clear to me that the final patch from the common series, "[PATCH common 4/4] mltools: Allow waiting for killed PIDs", had not been pushed (because now that patch would be superfluous)
Yup, this is not needed. Note we do still need (and have already pushed) the priority changes.
- "[PATCH virt-v2v v3 1/2] output: Permit output modes to wait on the local NBD server" is quite difficult to review without "-b", due to the reindentation; however, after I applied it locally, it was quite reviewable.
- The idea to implement kill+wait with a one-off callback function in virt-v2v, rather than pushing kill+wait down to libguestfs-common's mltools/on_exit, is nice (we only really need this in virt-v2v, and there we do centralize it), but the conceptual jump wasn't written up anywhere (... anywhere I could see anyway), and I kind of had to deduce the intent from the code... Such big changes are best put in commit message changelogs or the cover letters.
I added a couple of sentences to the commit message.
Long story short:
series Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks - hopefully this is right: https://github.com/libguestfs/virt-v2v/commit/e2a1a7b4dfb6a9e44260da10a7e702... https://github.com/libguestfs/virt-v2v/commit/2fbd578b4e6884a23063ad67ee36f0... RIch. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW