Richard W.M. Jones wrote:
On Mon, Aug 03, 2009 at 01:04:38PM +0200, Jim Meyering wrote:
Here's a patch series to make libguestfs use gnulib via a git submodule. The first thing I did was to look at the failures from "make syntax-check" and fix the config.h-related ones below. The others are now temporarily disabled via a variable in cfg.mk.
In general, yes we need this, please commit it and 'make it work'. A couple of additional problems noted below:
* examples/to-xml.c: Likewise. * examples/hello.c: Likewise.
I'm dubious about adding <config.h> to these files, since they are supposed to be examples, and therefore should work outside the
I had doubts too. One alternative is to exempt them by creating a file named .x-sc_RULE_NAME and listing the exempted names therein. One other alternative: guard the #inclusion: #if HAVE_CONFIG_H # include <config.h> #endif What do you prefer?
project. If people were to copy these files somewhere, then they would fail to compile or (perhaps worse) include some random config.h header.
+# |grep -vE '^(qsort|if|close|assert|fputc|free|N_|vir.*GetName|.*Unlock|virNodeListDevices|virHashRemoveEntry|freeaddrinfo|.*[fF]ree|xdrmem_create|xmlXPathFreeObject|virUUIDFormat|openvzSetProgramSentinal|polkit_action_unref)$' + +msg_gen_function = +msg_gen_function += DEBUG0 +msg_gen_function += DISABLE_fprintf +msg_gen_function += ERROR +msg_gen_function += ERROR0 +msg_gen_function += REMOTE_DEBUG +msg_gen_function += ReportError +msg_gen_function += VIR_FREE +msg_gen_function += VIR_INFO +msg_gen_function += VIR_USE_CPU
libvirt specific?
Yes. Good catch. I'll remove those before pushing.