On Tue, Feb 21, 2017 at 02:59:38PM +0100, Pino Toscano wrote:
On Saturday, 18 February 2017 08:05:27 CET Richard W.M. Jones wrote:
A very miscellaneous set of cleanups to how we handle the Windows registry in virt-v2v, firstboot, and inspection code. This should all be straightforward non-controversial refactoring. Some highlights:
- Add a new mllib Registry module containing various utility functions that are currently scattered all around.
IMHO it should be better named as WinRegistry, although I won't hold my breath on it.
The rest of the changes LGTM (even if I'm not familiar with this code base).
BTW there was a memory leak in the patches posted (fs->windows_{software,system}_hive not freed). I have fixed that in my latest version. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW