On Thu, Jul 20, 2017 at 05:16:40PM +0200, Pino Toscano wrote:
On Monday, 17 July 2017 18:55:24 CEST Richard W.M. Jones wrote:
Unlike previous ‘daemon: Reimplement ...’ patches, this does not reimplement the umount_all API completely (yet, but this implementation could be completed in future and then replace the C one). However it is necessary to have a version of umount_all which we can call from the OCaml inspection code. ---
Wouldn't it be easier to wrap the C implementation, for now? This way there is no functionality mismatch, and it can be used in both C and OCaml snippets.
That was the original plan, but because the original code calls reply_with_error it cannot be done. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html