On Wednesday, 27 November 2019 13:27:21 CET Pino Toscano wrote:
BTW is the colon-separated value for --path needed? Reading the other two patches of this series, I see the values are only a single directory every time. In this case, the proposal above can be simplified as:
my @paths = ('.'); [...] GetOptions( "path=s" => \@paths, [...]
Self-correction: there is one occurrence of that in patch #3: diff --git a/fish/Makefile.am b/fish/Makefile.am index dff56b2e2..932c66398 100644 --- a/fish/Makefile.am +++ b/fish/Makefile.am @@ -201,7 +201,7 @@ stamp-guestfish.pod: guestfish.pod guestfish-actions.pod guestfish-commands.pod $(PODWRAPPER) \ --man guestfish.1 \ --html $(top_builddir)/website/guestfish.1.html \ - --path $(srcdir) \ + --path $(srcdir):$(top_srcdir)/common/options \ --license GPLv2+ \ --warning ro-option \ $< However it can be easily changed to just add --path $(top_srcdir)/common/options to the podwrapper arguments. -- Pino Toscano