On Mon, Jul 13, 2015 at 11:58:07AM +0200, Pino Toscano wrote:
On Thursday 09 July 2015 13:39:33 Richard W.M. Jones wrote:
On Wed, Jul 08, 2015 at 04:42:18PM +0200, Pino Toscano wrote:
+ error (f_"subscription-manager configuration required for this operation")
This error message should refer to the --sm-config option in some way, so the error message is actionable.
---
Patches 1-5 are fine and can go upstream now.
I've not pushed them, as basically they move the ini reader from virt-builder to mllib.
I can't say that I'm overjoyed by the new config file format that we need here.
I basically made use of the ini configuration style as used elsewhere. Anything in particular that concerns you?
That virt-builder users will have to create a configuration file in order to enable s-m. There is no other virt-customize option where they have to create a configuration file, except for ones like '--commands-from-file' and '--password ...:file:...' which are special cases.
Is it not possible to encode the configuration settings into --sm-* parameters?
The idea is to have settings such as usernames, passwords, and maybe also channel pools in a separate configuration, so they are not shown in command line; this is similar to what is done in virt-customize --password, and also --password-file in virt-v2v.
Well, sort of. You can use --password entirely on the command line, or you can use a file, but the file: option exists because of security concerns. (virt-v2v --password-file is not very regular, but was added for VDSM) My question is, can we make s-m function with just: virt-builder --sm-credentials foo virt-builder --sm-credentials foo:password:123456 virt-builder --sm-credentials foo:file:/tmp/secret (or something in a similar spirit)?
What about quoting - what happens if the password contains quotes or newlines?
Right, fixed.
Thanks, -- Pino Toscano
_______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v