On Mon, Jun 07, 2010 at 01:37:40PM +0100, Matthew Booth wrote:
If an ESX guest has a snapshot, the path the libvirt driver gives us will look like: [yellow:storage1] RHEL4-X/RHEL4-X-000003.vmdk instead of: [yellow:storage1] RHEL4-X/RHEL4-X.vmdk The current path mangling code does take this into account.
As you say it's a flakey heuristic, but there doesn't seem to be any danger in it. So ACK. BTW your description here:
This change makes it use the current mechanism first, [...]
doesn't seem to match what the patch does. Surely the patch is trying the original name first? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora