Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1883802 Pino had added SATA disk parsing to libvirtd, for the sake of virt-v2v's VDDK and VCENTER connection URIs, in RHBZ#1883588. The second patch in this series seeks to parse SATA disks directly from VMX files ("-i vmx"), modeled after Pino's libvirtd patches, and Rich's recent NVMe disk parsing patch (see more precise references in the commit message). The first patch in the series fixes an unrelated bug in the "-i vmx" disk numbering. I discovered that bug because I didn't install a new guest with just SATA disk(s) on my ESXi server, but (out of lazyness) I added a new SATA disk to my existent Windows Server 2019 guest, which I had originally installed with a SCSI disk. Thanks, Laszlo Laszlo Ersek (2): "-i vmx -it ssh": fix non-unique "s_disk_id" input: -i vmx: Add support for SATA hard disks input/parse_domain_from_vmx.ml | 51 ++++++--- tests/test-v2v-i-vmx-7.expected | 23 ++++ tests/test-v2v-i-vmx-7.vmx | 110 ++++++++++++++++++++ tests/test-v2v-i-vmx.sh | 3 +- 4 files changed, 173 insertions(+), 14 deletions(-) create mode 100644 tests/test-v2v-i-vmx-7.expected create mode 100755 tests/test-v2v-i-vmx-7.vmx base-commit: 8643970f9791b1c90dfd6a2dd1abfc9afef1fb52 -- 2.19.1.3.g30247aa5d201