On Wed, Nov 16, 2011 at 08:29:55AM +0800, Wanlong Gao wrote:
I wasn't sure if you meant (a) remove the use of the constant here and replace it with a macro, or (b) allow users to specify other chunk sizes (eg. less than 1024 bytes, or not a multiple of 1024 bytes). [...] I meant (a) just for the code readable and the future maintenance?
OK, understood! I'm happy about 'chunk & 1023' since I know that 1024 bytes = 1K. Do you have a suggested symbol / macro that would make this clearer? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v