Hi guys, Here is a v3 of the series, including changes to answer Richard's comments. Cédric Bosdonnat (10): mllib: factorize code to add Checksum.get_checksum function Move xml and xpath_helpers OCAML code to mllib mllib: add Xml.parse_file helper lib/osinfo.c: Extract xml processing into a callback lib: extract osinfo DB traversing API mllib: ocaml wrapper for lib/osinfo builder: rename docs test script builder: add Index.write_entry function builder: add a template parameter to get_index Add a virt-builder-repository tool .gitignore | 3 + builder/Makefile.am | 86 +++- builder/builder.ml | 2 +- builder/index.mli | 3 + builder/index_parser.ml | 72 ++- builder/index_parser.mli | 8 +- builder/repository_main.ml | 487 +++++++++++++++++++++ .../{test-virt-builder-docs.sh => test-docs.sh} | 3 + builder/virt-builder-repository.pod | 183 ++++++++ docs/C_SOURCE_FILES | 2 +- lib/Makefile.am | 2 + lib/osinfo-iso.c | 464 ++++++++++++++++++++ lib/osinfo.c | 479 ++------------------ lib/osinfo.h | 27 ++ mllib/Makefile.am | 18 +- mllib/checksums.ml | 25 +- mllib/checksums.mli | 9 + mllib/osinfo-c.c | 100 +++++ mllib/osinfo.ml | 26 ++ mllib/osinfo.mli | 31 ++ {v2v => mllib}/xml-c.c | 47 +- {v2v => mllib}/xml.ml | 49 ++- {v2v => mllib}/xml.mli | 3 + {v2v => mllib}/xpath_helpers.ml | 0 {v2v => mllib}/xpath_helpers.mli | 0 v2v/Makefile.am | 17 +- v2v/test-harness/Makefile.am | 3 +- v2v/test-harness/dummy.c | 2 + 28 files changed, 1631 insertions(+), 520 deletions(-) create mode 100644 builder/repository_main.ml rename builder/{test-virt-builder-docs.sh => test-docs.sh} (89%) create mode 100644 builder/virt-builder-repository.pod create mode 100644 lib/osinfo-iso.c create mode 100644 lib/osinfo.h create mode 100644 mllib/osinfo-c.c create mode 100644 mllib/osinfo.ml create mode 100644 mllib/osinfo.mli rename {v2v => mllib}/xml-c.c (90%) rename {v2v => mllib}/xml.ml (79%) rename {v2v => mllib}/xml.mli (97%) rename {v2v => mllib}/xpath_helpers.ml (100%) rename {v2v => mllib}/xpath_helpers.mli (100%) create mode 100644 v2v/test-harness/dummy.c -- 2.11.0