Re: [Libguestfs] [PATCH v2 2/6] daemon: refactor tsk code
On Thursday, 25 August 2016 23:53:52 CEST Matteo Cafasso wrote:
Refactor logic in preparation for new APIs.
Signed-off-by: Matteo Cafasso <noxdafox(a)gmail.com>
---
Mostly LGTM, just a couple of minor notes.
+static int
+send_dirent_info(TSK_FS_FILE *fsfile, const char *path)
Nitpick wrt coding style.
+ /* Extract dirent information. */
+ memset (&dirent, 0, sizeof dirent);
I guess the comment that was below fits better:
/* Set dirent fields */
Thanks,
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)