On Mon, Feb 10, 2025 at 03:26:57PM -0500, Cole Robinson wrote:
On 2/10/25 11:28 AM, Richard W.M. Jones wrote:
Thanks, I pushed these as commit b3268a13bec.
Great, thanks. I had some questions in the cover letter FYI
This may still break some really old cases. Notable `unconfigure_xen` has a comment referencing RHEL 3, which lacks yum AFAIK. Which would cause Guest_packages.uninstall_command to error.
Maybe we don't care about RHEL-3? Or turn the error into a warning and be done with it?
Thoughts?
Right, sorry, meant to comment on this. We dropped support for RHEL 3 a couple of years ago, for other reasons: https://github.com/libguestfs/virt-v2v/commit/1ea99fb2a7aee63aabe02aa40e9429... Downstream in RHEL we don't support anything before RHEL 7 on current hosts: https://access.redhat.com/articles/1351473 So I think we're all good here.
I squashed them into one commit since they're logically a single change, and made a small whitespace change so that we don't go beyond 80 cols.
Noted. Is there any `make syntax-check` or style checking tools I should be aware of?
I think we used to have something like that but deleted it. Laszlo went through all the code a few years ago making sure everything was under 80 columns, so I'm trying to stick with that. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW