On Wed, 2016-07-06 at 19:11 +0100, Richard W.M. Jones wrote:
On Wed, Jul 06, 2016 at 05:33:01PM +0300, Maxim Perevedentsev wrote:
Hello everyone!
I have an issue with OpenSUSE-42.1 (I guess this is the only distro with btrfs snapshots by default). As we remember, list_filesystems returns btrfs snapshots along with devices.
<fs> list-filesystems /dev/sda1: swap btrfsvol:/dev/sda2/@: btrfs btrfsvol:/dev/sda2/@/.snapshots: btrfs btrfsvol:/dev/sda2/@/.snapshots/1/snapshot: btrfs btrfsvol:/dev/sda2/@/.snapshots/2/snapshot: btrfs ... btrfsvol:/dev/sda2/@/.snapshots/16/snapshot: btrfs /dev/sda2: btrfs
The btrfs snapshots are not block devices, so an error is thrown by RESOLVE_DEVICE macro in stubs.c. That means we will get an error trying to call blockdev - oriented functions at these devices.
=========================
After grepping "list_filesystems" issues were found in: - virt-sparsify (in-place and copying): is_lv - virt-filesystems: blockdev_getsize64
Already addressed, see https://github.com/libguestfs/libguestfs/commit/cf137ef30601f81fc017f6627ecf... The patch is also available in Virtualization/libguestfs package on build.opensuse.org, and should arrive in Tumbleweed soon (if not already arrived). -- Cedric