On Tue, Jun 08, 2010 at 10:50:05AM +0100, Matthew Booth wrote:
+# RHEL5 +# RHEL5x64 +# os = linux +# distro = rhel +# major_version = 5 [...] +# WindowsXP +# os = windows +# root->os_major_version = 5 +# root->os_minor_version = 1
While it's not especially important, I don't understand why you need to get the os_major_version field from the root node. It *should* be copied into the os node, even on Windows. See: http://git.annexia.org/?p=libguestfs.git;a=blob;f=perl/lib/Sys/Guestfs/Lib.p... Maybe this doesn't happen for some reason for Windows guests. If so, please let me know. Anyway, this patch fixes a serious bug in RHEV-M importing, so ACK. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/