On Fri, May 29, 2026 at 09:36:01AM +0100, Richard W.M. Jones via Libguestfs wrote:
On Fri, May 29, 2026 at 04:28:27AM -0400, Srihari Parimi wrote:
> Implement bind mount to overwrite /etc/resolv.conf instead of the
> current method of rename followed by copy. The bind mount method
> works even if the file is designated as immutable
>
> Fixes: RHEL-178556
This is technically correct, but best to use a URL here. It avoids
someone wondering how to decode this.
> Signed-off-by: Srihari Parimi <sparimi(a)redhat.com>
> ---
> daemon/sh.c | 100 ++++++++++++++++++++++++++--------------------------
> 1 file changed, 50 insertions(+), 50 deletions(-)
>
> diff --git a/daemon/sh.c b/daemon/sh.c
> index 74e003410..e603cfd92 100644
> --- a/daemon/sh.c
> +++ b/daemon/sh.c
> @@ -48,8 +48,8 @@ struct bind_state {
>
> struct resolver_state {
> bool mounted;
> + bool file_exists;
Can we call it something like 'sysrot_etc_resolv_conf_exists' ? It
sysroot_...
Rich.
--
Richard Jones, Virtualization Group, Red Hat
http://people.redhat.com/~rjones
Read my programming and virtualization blog:
http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html