On Wed, Nov 18, 2015 at 11:19:02AM +0100, Pino Toscano wrote:
On Monday 09 November 2015 23:02:15 Richard W.M. Jones wrote:
After fixing some warnings (see prior commits), we can now enable them in configure.ac. --- [...] -nw="$nw -Winline" # daemon.h's asprintf_nowarn
Disabling -Winline causes the Python binding code to fail with build with GCC < 4.9, because of the static inline functions in python/guestfs-py.h. See for example on CentOS 7.1 and openSUSE 13.1: https://ci.centos.org/view/libguestfs/job/libguestfs/label=libguestfs-ci-Cen... https://ci.centos.org/view/libguestfs/job/libguestfs/label=libguestfs-ci-ope...
Would it be acceptable to de-inline them into normal functions?
The -Winline warning looks completely useless. Who cares if a function can't be inlined? So enabling it was probably a mistake. Can we disable it (the warning) again? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v