On Thu, Feb 18, 2010 at 11:35:19AM +0000, Matthew Booth wrote:
These checks found not to be useful. --- lib/Sys/VirtV2V/Converter/Linux.pm | 28 ---------------------------- 1 files changed, 0 insertions(+), 28 deletions(-)
diff --git a/lib/Sys/VirtV2V/Converter/Linux.pm b/lib/Sys/VirtV2V/Converter/Linux.pm index 87eeeb3..1186430 100644 --- a/lib/Sys/VirtV2V/Converter/Linux.pm +++ b/lib/Sys/VirtV2V/Converter/Linux.pm @@ -133,14 +133,6 @@ sub convert sub _remap_block_devices { my ($guestos, $dom, $desc, $virtio) = @_; - die("remap_block_devices called without guestos argument") - unless defined($guestos); - die("remap_block_devices called without dom argument") - unless defined($dom); - die("remap_block_devices called without desc argument") - unless defined($desc); - die("remap_block_devices called without virtio argument") - unless defined($virtio);
That's because these can be undefined? ACK, I suppose, but maybe better to specify what is a valid parameter and what is not. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/