Re: [Libguestfs] [PATCH v3 1/2] Revert "python: fix call of Python handlers of events"

20 Feb 2023

On 2/17/23 18:45, Richard W.M. Jones wrote:
...
This reverts commit 85235aec837716f1ddb2926b9a59a02543195500.
---
 python/handle.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/python/handle.c b/python/handle.c
index bf639b5789..8eeabe60a7 100644
--- a/python/handle.c
+++ b/python/handle.c
@@ -139,7 +139,6 @@ guestfs_int_py_event_callback_wrapper (guestfs_h *g,
     goto out;
   }
-  Py_INCREF (args);
   py_r = PyObject_CallObject (py_callback, args);
   Py_DECREF (args);
   if (py_r != NULL)
The patch looks good, but I think the commit's subject line, and the
commit message, should be a bit more clear / verbose:

- we're only reverting a part of commit
85235aec837716f1ddb2926b9a59a02543195500

- the reason for doing this is that Py_BuildValue() always returns a new
reference
<https://docs.python.org/3/c-api/arg.html?highlight=py_buildvalue#c.Py_BuildValue>
(when it succeeds).

With those notes:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

    