On Mon, Jan 23, 2017 at 09:13:23PM -0600, Eric Blake wrote:
Begin the language binding followups to my new .zero callback, since Rich was indeed correct that we want them.
I'm more familiar with python and perl (at least to the point that I was able to modify the appropriate example files and prove to myself that the bindings worked), so I've started with those. I'm less familiar with ruby and ocaml, so I've left those for tomorrow (it will rely heavily on copy-and-paste); it is also a chance to review if my decision of requiring a return value in order to trigger the graceful fallback is the best approach.
The other methods (eg. trim) deal with this by having a separate method called "can_*" (eg. can_trim). Can we have a can_zero callback instead? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html