16 Jun
2023
16 Jun
'23
6:16 p.m.
On 08.06.23 16:56, Eric Blake wrote:
Widen the length field of NBDRequest to 64-bits, although we can assert that all current uses are still under 32 bits, because nothing ever puts us into NBD_MODE_EXTENDED yet. Thus no semantic change. No semantic change yet.
Signed-off-by: Eric Blake <eblake@redhat.com>
assertions about NBD_MAX_BUFFER_SIZE worth a note in commit message? trace eventsjk nbd_co_request_fail, nbd_co_request_fail, nbd_co_request_fail missed an update to 64bit Also, some functions use size_t. Should we move them to uint64_t for consistancy? - nbd_co_send_sparse_read - nbd_co_send_chunk_read - nbd_co_send_simple_reply but that may be another story -- Best regards, Vladimir