On Sat, 2010-04-03 at 10:51 +0100, Richard W.M. Jones wrote:
On Sat, Apr 03, 2010 at 10:22:29AM +0100, TJ wrote:
Hopefully this is my last issue raised as a result of the Debian packaging effort!
I see a warning from debhelper which suggests the linked library "libncurses" may actually be no longer required by "hivexsh". Is this so, or is it in preparation for some future use of the library?
dpkg-shlibdeps: warning: dependency on libncurses.so.5 could be avoided if "debian/hivex/usr/bin/hivexsh" were not uselessly linked against it (they use none of its symbols).
Does the attached patch fix the issue for you?
Yes
Can you also check that configure still finds readline:
checking for main in -lreadline... yes
Yes
and that it is still used by hivexsh.
Yes. Interestingly ldd suggests it is still linked to libncurses but I think that is via libreadline - confused me for a few minutes. $ ldd /usr/bin/hivexsh linux-gate.so.1 => (0x00884000) libhivex.so.0 => /usr/lib/libhivex.so.0 (0x008c3000) libreadline.so.6 => /lib/libreadline.so.6 (0x00a27000) libc.so.6 => /lib/tls/i686/cmov/libc.so.6 (0x00110000) libncurses.so.5 => /lib/libncurses.so.5 (0x00e2e000) /lib/ld-linux.so.2 (0x00323000) libdl.so.2 => /lib/tls/i686/cmov/libdl.so.2 (0x00b43000) $ ldd /lib/libreadline.so.6 linux-gate.so.1 => (0x0025f000) libncurses.so.5 => /lib/libncurses.so.5 (0x00ec3000) libc.so.6 => /lib/tls/i686/cmov/libc.so.6 (0x00995000) libdl.so.2 => /lib/tls/i686/cmov/libdl.so.2 (0x007c2000) /lib/ld-linux.so.2 (0x005fe000) $ strings /usr/bin/hivexsh | grep readline libreadline.so.6 rl_readline_name readline $ strings /usr/bin/hivexsh | grep curse $