On Wed, Jan 17, 2018 at 04:14:56PM -0600, Eric Blake wrote:
On 01/17/2018 02:53 PM, Richard W.M. Jones wrote:
This returns the plugin name, which for plugins is the same as the ordinary .name method (but for filters will be different). ---
Just as .name and .plugin_name can differ for filters, should we also have a way to report independent version numbers (via .version) for the filter, compared to the version of the underlying plugin (via .plugin_version)?
As it currently stands it's not necessary because main.c does: if (version) { const char *v; struct backend *b; display_version (); for_each_backend (b) { printf ("%s", b->name (b)); if ((v = b->version (b)) != NULL) printf (" %s", v); printf ("\n"); } exit (EXIT_SUCCESS); } with the output: $ ./nbdkit --filter offset --filter delay file --version nbdkit 1.1.26 offset 1.1.26 delay 1.1.26 file 1.1.26 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW